Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restore bot workflow to update attributions #9936

Merged
merged 9 commits into from
Jul 3, 2024

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Jun 11, 2024

Description

This PR reinstates the workflow that was removed in this PR. Additionally, a safeguard has been added to the workflow to prevent it from running on a fork.

Related issues

Fixes: #1550

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s requested a review from a team as a code owner June 11, 2024 10:40
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s force-pushed the feature/update-attributions-only-in-no-forks branch from 519d3e8 to 2b192fc Compare June 11, 2024 10:42
@cryptodev-2s cryptodev-2s changed the title chore: add bot workflow to update attributions chore: restore bot workflow to update attributions Jun 11, 2024
@cryptodev-2s cryptodev-2s added the DO-NOT-MERGE Pull requests that should not be merged label Jun 13, 2024
@cryptodev-2s
Copy link
Contributor Author

waiting for security team review of all workflows

@cryptodev-2s cryptodev-2s removed the DO-NOT-MERGE Pull requests that should not be merged label Jun 26, 2024
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, but looks good to me regardless.

.github/workflows/update-attributions.yml Outdated Show resolved Hide resolved
.github/workflows/update-attributions.yml Outdated Show resolved Hide resolved
.github/workflows/update-attributions.yml Show resolved Hide resolved
mcmire
mcmire previously approved these changes Jun 26, 2024
Copy link

sonarqubecloud bot commented Jul 1, 2024

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cryptodev-2s cryptodev-2s merged commit 8db254a into main Jul 3, 2024
32 checks passed
@cryptodev-2s cryptodev-2s deleted the feature/update-attributions-only-in-no-forks branch July 3, 2024 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
@metamaskbot metamaskbot added the release-7.27.1 Issue or pull request that will be included in release 7.27.1 label Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.27.1 Issue or pull request that will be included in release 7.27.1 team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants