chore: call getPermissions on accountsChanged when using extension #1185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Historically, we used to call sdk.terminate() when receiving an accountsChanged=[] event thinking that permissions had been revoked from the extension.
The problem with this is that EIP-1193 requires the extension to send accountsChanged=[] when locking the extension (to be changed) meaning that the accounts are no longer available and that it needs to e unlocked for them to be available again.
It is scheduled for extension to stop emitting this event but because we need to keep backward compatibility until most users have the new extension version, we need to implement a workaround for this specific case. Upon discussing with wallet-api members it was decided that SDK would call getPermissions when receiving accountsChanged=[] since this call returns permissions even when the wallet is locked.
The flow should then be:
a) if no permissions are returned → Terminate
b) If permissions are received do nothing
References
Checklist