Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add external_links to all services to enable access to domains in the web container #22

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonhattan
Copy link
Contributor

No description provided.

@juanjol
Copy link
Collaborator

juanjol commented Dec 10, 2024

While I like the idea of adding external_links automatically, I see a problem with having a dependency on Python. The main premise of Aljibe is not needing to have anything installer on the host beyond docker and ddev, not even composer or php, so adding a dependency with python is totally out of scope. We have to work along these lines but adapt the script to bash or sh.

@juanjol juanjol marked this pull request as draft December 10, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants