Ns15/remove mime multipart dependency #165
Conversation
nsant15
force-pushed
the
ns15/remove_mime_multipart_dependency
branch
from
a1b418b
to
b224349
Compare
This was done to remove a crypto dependency in the textnonce crate. Most functionality from mime_multipart has been copied with the relevant copyright and licensing. mime_multipart functions replicated into multipart/related, and moved multipart/related.rs functions into a new directory.
nsant15
force-pushed
the
ns15/remove_mime_multipart_dependency
branch
from
cf2fa6f
to
0b74852
Compare
There was a problem hiding this comment.
You've added a mixture of MIT, Apache and MIT/Apache dual licensed code to a repo which is Apache 2.0 licensed.
In addition, you haven't signed the DCO - presumably because you can't, because this isn't your own work.
As such, it's going to be difficult to accept this code in the current form.
In addition, this code represents a breaking change.
| @@ -1,38 +0,0 @@ | |||
| //! Helper functions for multipart/related support | |||
There was a problem hiding this comment.
Where has this file gone?
There was a problem hiding this comment.
I have moved the functions into the mod.rs file of the new directory (as mentioned in the commit message). I thought this would have the same effect as having the file as it was before.
I did the licensing in this way as that is how I interpreted how to do it from @james-jra's suggestions. How would you recommend rectifying this if it is a problem? I thought that the DCO could only be signed after reviewing. Is the breaking change preventable? The replication of the crate functions is needed to remove the crypto dependency on the textnonce crate. |
Removed cryptodependency in textnonce crate by removing mime_multipart dependency and replicating required code with appropriate copyrights.