Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nested secrets in secrets.json #328

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow nested secrets in secrets.json #328

wants to merge 3 commits into from

Commits on May 8, 2023

  1. Allow nested secrets in secrets.json 

    Prior to this change, if secrets.json had nested secrets we would see
this error (example):

```
sops-install-secrets: Manifest is not valid: secret jenkins-nix-ci/cachix-auth-token/description in /nix/store/wxm763za3rbrpiijfbgss9g5ll0sd29z-secrets.json is not valid: Key 'jenkins-nix-ci' does not refer to a dictionary
```

The reason is that introspecting the map key to be `interface` fails,
when it is in fact a string.
    @srid
    srid committed May 8, 2023
    Configuration menu
    Copy the full SHA
    2bac628 View commit details
    Browse the repository at this point in the history

  2. Show the key type in error message

    @srid
    srid committed May 8, 2023
    Configuration menu
    Copy the full SHA
    d4a42a9 View commit details
    Browse the repository at this point in the history

  3. recurseSecretKey: handle json and yaml differently 

    Because the map's key type is different for both.
    @srid
    srid committed May 8, 2023
    Configuration menu
    Copy the full SHA
    f4b1471 View commit details
    Browse the repository at this point in the history