feat(modules/home-manager): add support for configuring environment variables #615
Conversation
modules/home-manager/sops.nix
Outdated
| Environment variables to set before calling sops-install-secrets. | ||
|
|
||
| The values are placed in single quotes and not escaped any further to | ||
| allow usage of command substitutions for more flexibility. To properly quote |
There was a problem hiding this comment.
Is this actually true? I don't think systemd will do command substitution.
There was a problem hiding this comment.
I don't now about launchd, but it also looks to me that it should be the same.
There was a problem hiding this comment.
That may not be true. I copied the description for the environment option from the NixOS module at modules/sops/default.nix.
I also have only tested the launchd code path. It does work on macOS. I do not have access to a NixOS linux system. Hopefully someone can test the systemd code path.
marksisson
force-pushed
the
patches/add-environment-option-to-home-manager-module
branch
from
31b34ca
to
c8c892a
Compare
|
@SebTM could you test linux? |
|
Hey, sorry for the delay - I can test it but would appreciate a test-case/instructions? |
|
@SebTM for now it's enough if you just make sure it doesn't break your existing usage. |
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
|
@mergify rebase |
Added support for configuring environment variables before calling `sops-install-secrets`. Introduced a new `environment` option which allows specifying environment variables. Modified systemd service and launchd agent to use the specified environment variables.
✅ Branch has been successfully rebased |
Mic92
force-pushed
the
patches/add-environment-option-to-home-manager-module
branch
from
c8c892a
to
7a8b208
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d089e74 |
Add support for configuring environment variables before calling
sops-install-secrets. Introduce a newenvironmentoption which allows specifying environment variables. Modify systemd service and launchd agent to use the specified environment variables.