Improve persistentIdSet performance

MichaelWest22 · Dec 19, 2024 · 7fe3f25 · 7fe3f25
1 parent 35c06a1
commit 7fe3f25
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/idiomorph.js b/src/idiomorph.js
@@ -1204,15 +1204,17 @@ var Idiomorph = (function () {
          * @returns {Set<string>} the id set of all persistent nodes that exist in both old and new content
          */
         function persistentIdSet(oldContent, newContent) {
-            let idSet = new Set();
+            let matchIdSet = new Set();
+            let oldIdSet = new Set();
             for (const oldNode of nodesWithIds(oldContent)) {
-                for (const newNode of nodesWithIds(newContent)) {
-                    if (oldNode.id === newNode.id) {
-                        idSet.add(oldNode.id);
-                    }
+                oldIdSet.add(oldNode.id);
+            }
+            for (const newNode of nodesWithIds(newContent)) {
+                if (oldIdSet.has(newNode.id)) {
+                    matchIdSet.add(newNode.id);
                 }
             }
-            return idSet;
+            return matchIdSet;
         }
 
         //=============================================================================