Fixed bug where [clientid] was not being replaced with topic name.

rsmb/src/MQTTProtocol.c

@@ -876,6 +876,10 @@ int MQTTProtocol_handleDisconnects(void* pack, int sock, Clients* client)
  */
 void MQTTProtocol_processRetaineds(Clients* client, char* topic, int qos, int priority)
 {
+    // NEW
+    Messages* stored = NULL; /* to avoid duplication of data where possible */
+    int clean_needed = 0;
+    // NEW
 	List* rpl = NULL;
 	ListElement* currp = NULL;
 #if defined(QOS0_SEND_LIMIT)
@@ -887,27 +891,69 @@ void MQTTProtocol_processRetaineds(Clients* client, char* topic, int qos, int pr
 	while (ListNextElement(rpl, &currp))
 	{
 		int curqos;
-		Publish publish;
+		Publish lPublish;
 		Messages* p = NULL;
 		RetainedPublications* rp = (RetainedPublications*)(currp->content);
 
-		publish.payload = rp->payload;
-		publish.payloadlen = rp->payloadlen;
-		publish.topic = rp->topicName;
+		lPublish.payload = rp->payload;
+		lPublish.payloadlen = rp->payloadlen;
+		lPublish.topic = rp->topicName;
 		curqos = (rp->qos < qos) ? rp->qos : qos;
 #if defined(QOS0_SEND_LIMIT)
 		if (curqos == 0)
 			++qos0count;
 		if (qos0count > bstate->max_inflight_messages) /* a somewhat arbitrary criterion */
 		{
-			if (MQTTProtocol_queuePublish(client, &publish, curqos, 1, priority, &p) == SOCKET_ERROR)
+			if (MQTTProtocol_queuePublish(client, &lPublish, curqos, 1, priority, &p) == SOCKET_ERROR)
 				break;
 		}
 		else
 		{
 #endif
-			if (Protocol_startOrQueuePublish(client, &publish, curqos, 1, priority, &p) == SOCKET_ERROR)
-				break;
+		    // NEW
+		    if (client)
+            {
+		        Publish *publish = &lPublish;
+//                Clients* pubclient = (Clients*)(curnode->content);
+                Clients* pubclient = client;
+                int retained = 0;
+                Messages* saved = NULL;
+                char* original_topic = publish->topic;
+
+#if !defined(NO_BRIDGE)
+                if (pubclient->outbound || pubclient->noLocal)
+                {
+                    retained = publish->header.bits.retain; /* outbound and noLocal mean outward/inward bridge client,
+                                                                                                so keep retained flag */
+                    if (pubclient->outbound)
+                    {
+                        Bridge_handleOutbound(pubclient, publish);
+                        if (publish->topic != original_topic)
+                        { /* handleOutbound has changed the topic, so we musn't used the stored pub which
+                                contains the original topic */
+                            saved = stored;
+                            stored = NULL;
+                        }
+                    }
+                }
+#endif
+                if (Protocol_startOrQueuePublish(pubclient, publish, qos, retained, priority, &stored) == SOCKET_ERROR)
+                {
+                    pubclient->good = pubclient->connected = 0; /* flag this client as needing to be cleaned up */
+                    clean_needed = 1;
+                }
+                if (publish->topic != original_topic)
+                {
+                    stored = saved;  /* restore the stored pointer for the next loop iteration */
+                    free(publish->topic);
+                    publish->topic = original_topic;
+                }
+            }
+		    // NEW
+
+		    // OLD
+		    //if (Protocol_startOrQueuePublish(client, &publish, curqos, 1, priority, &p) == SOCKET_ERROR)
+		    //	break;
 #if defined(QOS0_SEND_LIMIT)
 		}
 #endif

rsmb/src/MQTTSPacket.c

@@ -193,7 +193,7 @@ void* MQTTSPacket_Factory(int sock, char** clientAddr, struct sockaddr* from, ui
 	data = MQTTSPacket_parse_header( &header, data ) ;
 
 	/* In case of Forwarder Encapsulation packet, Length: 1-octet long, specifies the number of octets up to the end
-	 * of the �Wireless Node Id� field (incl. the Length octet itself). Length does not include length of payload
+	 * of the �Wireless Node Id� field (incl. the Length octet itself). Length does not include length of payload
 	 * (encapsulated MQTT-SN message itself).
 	 */
 	if (header.type != MQTTS_FRWDENCAP && header.len != n)
@@ -240,7 +240,7 @@ char* MQTTSPacket_parse_header( MQTTSHeader* header, char* data ) {
 
 	/* The Length field is either 1- or 3-octet long and specifies the total number of octets contained in
 	 *    the message (including the Length field itself).
-	 * If the first octet of the Length field is coded �0x01� then the Length field is 3-octet long; in this
+	 * If the first octet of the Length field is coded �0x01� then the Length field is 3-octet long; in this
 	 *    case, the two following octets specify the total number of octets of the message (most-significant
 	 *    octet first). Otherwise, the
 	 * Length field is only 1-octet long and specifies itself the total number of octets contained in the
@@ -448,9 +448,11 @@ void* MQTTSPacket_publish(MQTTSHeader header, char* data)
 	char* enddata = &data[header.len - 2];
 	int topicLen = 0;
 	int datalen = 0;
+	int headerlen;
 
 	FUNC_ENTRY;
 	//printf("publish header.len %d\n", header.len);
+	headerlen = (header.len > 255) ? 9 : 7;
 	pack = malloc(sizeof(MQTTS_Publish));
 	pack->header = header;
 	pack->flags.all = readChar(&curdata);
@@ -477,13 +479,13 @@ void* MQTTSPacket_publish(MQTTSHeader header, char* data)
 	pack->msgId = readInt(&curdata);
 	if (pack->flags.topicIdType == MQTTS_TOPIC_TYPE_NORMAL && pack->flags.QoS == 3)
 	{
-		datalen = header.len - 7 - topicLen;
+		datalen = header.len - headerlen - topicLen;
 		memcpy(pack->shortTopic, curdata, topicLen);
 		pack->shortTopic[topicLen] = '\0';
 		curdata += topicLen;
 	}
 	else
-		datalen = header.len - 7;
+		datalen = header.len - headerlen;
 	pack->data = malloc(datalen);
 	memcpy(pack->data, curdata, datalen);
 	pack->dataLen = datalen;

rsmb/src/MQTTSProtocol.c

@@ -972,9 +972,7 @@ int MQTTSProtocol_handleSubscribes(void* pack, int sock, char* clientAddr, Clien
 	else if (sub->flags.topicIdType == MQTTS_TOPIC_TYPE_PREDEFINED && client != NULL && sub->topicId != 0)
 	{
 		char *predefinedTopicName = MQTTSProtocol_getPreDefinedTopicName(client, sub->topicId) ;
-		// copy the topic name as it will be freed by subscription engine
-		topicName = malloc(strlen(predefinedTopicName)+1);
-		strcpy(topicName, predefinedTopicName);
+		topicName = MQTTSProtocol_replaceTopicNamePlaceholders(client, predefinedTopicName);
 		topicId = sub->topicId;
 	}