Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST contribution #972

Closed

Conversation

ChristianAnglarill
Copy link

The address of this metadata in step 2 of the "Contribute to a Microsoft Learn documentation article," was giving issues due to the period at the end of the metadata location.

learn.microsoft.com/contribute/content. -->Does not work

learn.microsoft.com/contribute/content -->Works

Contributor guide pull request

Thanks for contributing to the Microsoft Learn contributor guide. Please read these instructions for processing your pull request (PR). Once you've read this text, delete it and write a brief description of the changes you're proposing.

Quality control

  • 1. Successful build with no warnings: Review the build status to make sure all checks are green (Succeeded).

  • 2. #Sign-off: Once the PR is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the PR. Signing off means the document is ready for review and can be published at any time.

Merge and publish

  • All PRs to this repository are manually reviewed and merged.
  • Once all feedback on the PR is addressed, we'll merge the PR into the main branch.

Need help?

  • If you have an open PR, tag the PR reviewers in comment with your question: @carlyrevier, @jehchow
  • Open an issue in this repo and tag the PR reviewers.

The address of this metadata in step 2 of "Edit the article," was giving issues due to the period at the end of the metadata location.

learn.microsoft.com/contribute/content.  -->Does not work

learn.microsoft.com/contribute/content  -->Works
Copy link

Learn Build status updates of commit 1ee0564:

💡 Validation status: suggestions

File Status Preview URL Details
Contribute/content/index.md 💡Suggestion View Details

Contribute/content/index.md

  • Line 22, Column 194: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://review.learn.microsoft.com/help' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@ChristianAnglarill
Copy link
Author

#hold-off

@carlyrevier
Copy link
Collaborator

@ChristianAnglarill - Thanks for pointing this out. That period is meant to be the period at the end of the sentence, but I see why this is confusing if you're copying and pasting the address from the module. I'll open a PR to fix it in the repo where this content lives. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants