-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sampling-classic-api.md #55
Conversation
Updating link for Python fixed rate sampling in the table - the old one is sending customer to the deprecated Open Census
@brafonso7 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit c87c962:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/azure-monitor/app/sampling-classic-api.md | Details |
articles/azure-monitor/app/sampling-classic-api.md
- Line 44, Column 115: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/azure-monitor/app/opentelemetry-configuration?tabs=python#enable-sampling' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 44, Column 115: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/azure-monitor/app/opentelemetry-configuration?tabs=python#enable-sampling' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit 0ae3b84: 💡 Validation status: suggestions
articles/azure-monitor/app/sampling-classic-api.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
@AaronMaxwell any chance this change can be made? |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
@AaronMaxwell any news here? |
Because this PR was created in the public repo, only the listed author can sign off on updates. You can wait for approval from the author or you can close this PR and make the change in the private repo Read about authors working in the public repo for more information. If you need help getting set up to work in the private repo, see Get started contributing to the Microsoft Learn platform. After you make your changes in the private repo, review the articles on staging, and fix any validation issues, you can add the Thanks |
This article explicitly refers to the Classic SDK, so we must keep the link to the deprecated and archived OpenCensus documentation. Customers are directed to the appropriate OpenTelemetry documentation at the top of this article. #please-close |
Updating link for Python fixed rate sampling in the table - the old one is sending customer to the deprecated Open Census