Update to httpCompression attributes #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @bangbingsyb |
bangbingsyb
requested changes
Nov 27, 2018
| | [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. | | ||
| | [`staticTypes`](statictypes/index.md) | Optional element. <br><br>Specifies configuration settings for static compression. | | ||
| | [`scheme`](scheme.md) | Optional element. <br><br>Specifies the compression scheme (Gzip or Deflate) IIS uses to compress client requests. This element can only be configured at server level. | | ||
| | [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. This element can be configured at site level. | |
There was a problem hiding this comment.
Many thanks for making the change for us!
Minor change requested: In fact, dynamicTypes and staticTypes are only allowed to be configured at site level since IIS 10.0 and above. Before IIS 10.0, they can only be configured at server level.
There was a problem hiding this comment.
@bangbingsyb use the suggestion mechanism so I can accept your suggestion, then I'll S&M this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to how elements and attributes of httpCompression work.