Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize PSList docs and remove duplicate parameter definition #819

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nir9
Copy link

@nir9 nir9 commented Aug 3, 2024

Problem: Current PSList documentation references some legacy like Windows 2K and MSDN, and also defines the name parameter twice.

Solution: Move the duplicate definition of the name parameter as an initial example, and remove legacy from the doc.

Copy link
Contributor

Learn Build status updates of commit 037b2ab:

⚠️ Validation status: warnings

File Status Preview URL Details
sysinternals/downloads/pslist.md ⚠️Warning View Details

sysinternals/downloads/pslist.md

  • Line 42, Column 18: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/windows/win32/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 42, Column 18: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/windows/win32/' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 366bdee:

⚠️ Validation status: warnings

File Status Preview URL Details
sysinternals/downloads/pslist.md ⚠️Warning View Details

sysinternals/downloads/pslist.md

  • Line 42, Column 18: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/windows/win32/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 42, Column 18: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/windows/win32/' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 831d072:

✅ Validation status: passed

File Status Preview URL Details
sysinternals/downloads/pslist.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant