allow breaking system packages

MiczFlor · Nov 3, 2023 · ef235d7 · ef235d7
1 parent 84128dd
commit ef235d7
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 28 deletions.
diff --git a/components/gpio_control/install.sh b/components/gpio_control/install.sh
@@ -16,10 +16,8 @@ systemctl stop phoniebox-gpio-buttons.service
 systemctl disable phoniebox-gpio-buttons.service
 
 echo 'Install all required python modules'
-# Use a venv as Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
-python3 -m venv .venv
-source .venv/bin/activate
-python3 -m pip install --upgrade --force-reinstall -r requirements.txt
+# Allow breaking system packages (as 2.x is legacy) since Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
+python3 -m pip install --upgrade --force-reinstall -r requirements.txt --break-system-packages
 
 echo
 echo 'Installing GPIO_Control service'

diff --git a/components/rfid-reader/PN532/setup_pn532.sh b/components/rfid-reader/PN532/setup_pn532.sh
@@ -33,10 +33,8 @@ else
 fi
 
 printf "Installing Python requirements for PN532...\n"
-# Use a venv as Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
-sudo python3 -m venv .venv
-source .venv/bin/activate
-sudo python3 -m pip install --upgrade --force-reinstall -q -r "${JUKEBOX_HOME_DIR}"/components/rfid-reader/PN532/requirements.txt
+# Allow breaking system packages (as 2.x is legacy) since Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
+sudo python3 -m pip install --upgrade --force-reinstall -q -r "${JUKEBOX_HOME_DIR}"/components/rfid-reader/PN532/requirements.txt --break-system-packages
 
 printf "Configure RFID reader in Phoniebox...\n"
 cp "${JUKEBOX_HOME_DIR}"/scripts/Reader.py.experimental "${JUKEBOX_HOME_DIR}"/scripts/Reader.py

diff --git a/components/rfid-reader/RC522/setup_rc522.sh b/components/rfid-reader/RC522/setup_rc522.sh
@@ -17,10 +17,8 @@ printf "Please make sure that the RC522 reader is wired up correctly to the GPIO
 question "Continue"
 
 printf "Installing Python requirements for RC522...\n"
-# Use a venv as Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
-sudo python3 -m venv .venv
-source .venv/bin/activate
-sudo python3 -m pip install --upgrade --force-reinstall -q -r "${JUKEBOX_HOME_DIR}"/components/rfid-reader/RC522/requirements.txt
+# Allow breaking system packages (as 2.x is legacy) since Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
+sudo python3 -m pip install --upgrade --force-reinstall -q -r "${JUKEBOX_HOME_DIR}"/components/rfid-reader/RC522/requirements.txt --break-system-packages
 
 printf "Activating SPI...\n"
 sudo raspi-config nonint do_spi 0

diff --git a/scripts/RegisterDevice.py.Multi b/scripts/RegisterDevice.py.Multi
@@ -32,11 +32,11 @@ def setupPN532():
         print(str(output))
         return False
     print("Installing Python requirements for PN532...\n")
-    # Use a venv as Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
+    # Allow breaking system packages (as 2.x is legacy) since Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
     runCmd("sudo python3 -m venv .venv")
     runCmd("source .venv/bin/activate")
     runCmd("sudo python3 -m pip install --upgrade --force-reinstall "
-           "-q -r {}/components/rfid-reader/PN532/requirements.txt".format(JUKEBOX_HOME_DIR))
+           "-q -r {}/components/rfid-reader/PN532/requirements.txt --break-system-packages".format(JUKEBOX_HOME_DIR))
     print("Done")
     return True
 
@@ -47,11 +47,11 @@ def setupMFRC522():
     if not answer or answer[0] != 'Y':
         return False
     print("Installing Python requirements for RC522...\n")
-    # Use a venv as Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
+    # Allow breaking system packages (as 2.x is legacy) since Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
     runCmd("sudo python3 -m venv .venv")
     runCmd("source .venv/bin/activate")
     runCmd("sudo python3 -m pip install --upgrade --force-reinstall "
-           "-q -r {}/components/rfid-reader/RC522/requirements.txt".format(JUKEBOX_HOME_DIR))
+           "-q -r {}/components/rfid-reader/RC522/requirements.txt --break-system-packages".format(JUKEBOX_HOME_DIR))
     print("Done")
     return True
 

diff --git a/scripts/installscripts/buster-install-default.sh b/scripts/installscripts/buster-install-default.sh
@@ -872,18 +872,14 @@ install_main() {
         ${apt_get} ${allow_downgrades} install libspotify12 python3-cffi python3-ply python3-pycparser python3-spotify
 
         # Install necessary Python packages
-        # Use a venv as Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
-        sudo python3 -m venv .venv
-        source .venv/bin/activate
-        sudo python3 -m pip install --upgrade --force-reinstall -q -r "${jukebox_dir}"/requirements-spotify.txt
+        # Allow breaking system packages (as 2.x is legacy) since Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
+        sudo python3 -m pip install --upgrade --force-reinstall -q -r "${jukebox_dir}"/requirements-spotify.txt --break-system-packages
     fi
 
     # Install more required packages
     echo "Installing additional Python packages..."
-    # Use a venv as Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
-    sudo python3 -m venv .venv
-    source .venv/bin/activate
-    sudo python3 -m pip install --upgrade --force-reinstall -q -r "${jukebox_dir}"/requirements.txt
+    # Allow breaking system packages (as 2.x is legacy) since Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
+    sudo python3 -m pip install --upgrade --force-reinstall -q -r "${jukebox_dir}"/requirements.txt --break-system-packages
 
     samba_config
 
@@ -1017,10 +1013,8 @@ install_main() {
 
     # GPIO-Control
     if [[ "${GPIOconfig}" == "YES" ]]; then
-        # Use a venv as Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
-        sudo python3 -m venv .venv
-        source .venv/bin/activate
-        sudo python3 -m pip install --upgrade --force-reinstall -q -r "${jukebox_dir}"/requirements-GPIO.txt
+        # Allow breaking system packages (as 2.x is legacy) since Bookworm implemented PEP668 https://stackoverflow.com/a/75696359
+        sudo python3 -m pip install --upgrade --force-reinstall -q -r "${jukebox_dir}"/requirements-GPIO.txt --break-system-packages
         sudo systemctl enable phoniebox-gpio-control.service
         if [[ ! -f "${jukebox_dir}"/settings/gpio_settings.ini ]]; then
             cp "${jukebox_dir}"/misc/sampleconfigs/gpio_settings.ini.sample "${jukebox_dir}"/settings/gpio_settings.ini