docker: optimizations

[notapirate]

The scope of this work is to make the docker environment work out of the box on linux hosts (which it didn't so far for me), reduce errors and warnings to a minimum, and reduce config adjustments for the docker environment if possible.
On Linux hosts, the pulseaudio socket is 'volumed' to the docker containers to be used by dockers pulseaudio. Additionally the UID has to match, which made some adjustments for windows/mac necessary too.

Changes were successfully tested on Linux (Arch) and Windows 10. Mac is untested; the Mac config seems to be closer to the Windows config than to the Linux config, so I adjusted it accordingly.

[pabera]

Thanks for the effort. I will try to test your changes on Mac in the next couple of days and merge it accordingly!

[pabera]

Can you merge the most recent PRs because they will resolve the failing checks above

[pabera]

Works ok in Mac as well. I do get an error in the Jukebox container but I believe this is related to something else, my personal set up. This is not a blocker.

jukebox  | 146:daemon.py          - jb.daemon            - MainThread      - ERROR    - Plugins with errors during load: player

[pabera]

Why don't we want to ignore this anymore?

[notapirate]

The jukebox calls git to show some git values on startup. Without the .git folder this runs into an error. I know it's not a vital function, but I wanted to resolve warnings and errors wherever possible, so when a "real" error occurs you don't get distracted by these "built-in" errors.

[pabera]

Hm. I understand the reasoning behind it. But this folder can grow a lot over time. So maybe the best approach would be to remove the git command? If it runs into errors, it doesn't work anyways and might be useful.

[notapirate]

Re-added .git along with hidden github dirs and added the git errors to the known to-be-ignored errors in the doc

[pabera]

Why do you move them out of the global docker-compose and duplicate them in the individual ones? Since they are the same in all OS docker compose, they can be unified here.

[notapirate]

They are different in the linux-as-host configuration, they are mapped to /home/pi instead to /root because the linux config uses the pi user in combination with the running users UID to connect to the pulseaudio socket.

[pabera]

But they seem to be the same in Windows and Mac. You could use them as default in the docker-compose.yml and only overwrite them in docker-compose-linux.yml. This is how it works.

[notapirate]

Done; now docker-compose.windows.yml is completely empty so I removed it

[pabera]

Shouldn't that be also just http://localhost:3000?

[notapirate]

localhost is changed to 0.0.0.0 by jukebox. I noticed that on windows I only have a route that routes traffic from 0.0.0.0 to my physical network adapter, so the jukebox could not connect. On another windows with docker I noticed that another network route from 0.0.0.0 to the docker network adapter exists, so I'm not sure why it is missing on my installation.

Anyhow I figured that using host.docker.internal on windows might work on more installations (including mine), but if you want I'll undo that change. For mac, my impression was that host.docker.internal also exists and should work, but I'm not sure and can't test.

[pabera]

host.docker.internal does not work for me on Mac. Maybe we can add a comment mentioning both, so it works for everyone depending on their set up.

[notapirate]

Doc changed for Mac to localhost:3000

[pabera]

At least in Mac, it only works with localhost:3000

[notapirate]

OK good to know, then I'll change it back.
Do you know if that host entry host.docker.internal exists on Mac?

[pabera]

See above

[pabera]

I was able to get it to work. We need to update the docs in another place. The path has changed from /home/pi to /root. Since this is used in settings.yaml, the docs require an update.

[notapirate]

I was able to get it to work. We need to update the docs in another place. The path has changed from /home/pi to /root. Since this is used in settings.yaml, the docs require an update.

I didn't find settings.yaml, do mean jukebox.yaml? Only the host value needs to be changed now as written in jukebox.overrides.yaml. Update all relative paths (../..) in to /home/pi/RPi-Jukebox-RFID is no longer needed, thats why I removed that line from the doc. mpd is run as user now (root user for Windows/Mac host, pi user for Linux host) and the config is always in ~/.config/mpd/mpd.conf.