Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unavailable repo for pi-rc522 #2075

Merged
merged 5 commits into from
Oct 10, 2023
Merged

fix unavailable repo for pi-rc522 #2075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eab4636
fix unavailable repo for pi-rc522. Use fix version to ensure compatib…
AlvinSchiller Oct 7, 2023
606a317
build trigger
AlvinSchiller Oct 7, 2023
923db30
REVERT build trigger
AlvinSchiller Oct 7, 2023
d1a2959
fixed sphinx gpiozero version for pyton < 3.8
AlvinSchiller Oct 8, 2023
299641b
fixed sphinx gpiozero version for pyton >= 3.8
AlvinSchiller Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/sphinx/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ readthedocs-sphinx-search
# Install packages for documentation build from package repository
# that are installed on the PI via APT
RPi.GPIO
gpiozero
gpiozero<2.0.0;python_version<'3.8'
gpiozero;python_version>='3.8'
9 changes: 1 addition & 8 deletions src/jukebox/components/rfid/hardware/rc522_spi/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
# RC522 related requirements
# You need to install these with `sudo python3 -m pip install --upgrade --force-reinstall -q -r requirements.txt`

# pi-rc522 use latest version from Github
# This is the original versions. Seems unmaintained for the moment
# git+https://github.com/ondryaso/pi-rc522.git#egg=pi-rc522

# The fork of kevinvalk has some good improvements
# https://github.com/kevinvalk/pi-rc522
# Get the kevinvalk fork yet again from a different fork which ensures compatibility with the Phoniebox
git+https://github.com/ChisSoc/pi-rc522.git#egg=pi-rc522
pi-rc522==2.3.0
Copy link
Collaborator

@pabera pabera Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get the kevinvalk fork yet again from a different fork which ensures compatibility with the Phoniebox

This makes me curious why ChisSoc had used their own fork instead of the fork from kevinvalk.

Since the dependency from ChisSoc has been deleted, we can't check if had updated some of the code. Let's hope were no major updates.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it was for compatibility, so further changes to the kevinvalk fork wouldn't break things in phoniebox, as it was always the latest commit used. Ironically it was now the case with his fork.
With the specific release in the original repo this is not a problem anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check if i have maybe an old installation somewhere on sd. Maybe there is a way to extract the files and compare them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately i dont have an old installation. Does someone of you maybe have one?
The installed files can be found at "/usr/local/lib/python3.9/dist-packages/pirc522" and copied for comparison.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pirc522.zip
Here is the content from a installation from June 4th. Hope it helps.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pirc522.zip Here is the content from a installation from June 4th. Hope it helps.

was this a 2.x or 3.x installation? Looks like 2.x from the diff.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 2.4.0. You needed 3.x? Then I'm sorry... 😢

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, was about 3.x.
But thanks anyway :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to pick-up this older discussion as I realized a difference when not using ChisSoc's version. My Mifare Ultralight C sticker do not work on a minimal hardware setup (battery powered RPi Zero 2) with the current rc522 package, but were fine with ChisSoc's version. I was unable to identify the actual issue but found that using the read_id function of the current rc522 package does the job properly. See my suggestion #2214.