-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified Test runs in Docker #2082
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed now obsolete "*_altuser" Dockerfile
makes sure that the installation script uses the current repo/branch
only include the scripts that are needed. Otherwise every code change will invalidate the container cache. changed internal path of container and test scripts
changed thestructure to use the cache as much as possible. repo url -> packages -> user -> scripts
with ref instead of ref_name pull request will get a different cache
to be compatible with containers
get rid of warning "debconf: unable to initialize frontend: Dialog" export DEBIAN_FRONTEND=noninteractive does not work with sudo
s-martin
approved these changes
Oct 20, 2023
Cool enhancement, thanks! Anything missing from your side otherwise I would merge it? I would also manually adapt my Bookworm PR on the new implementation (still struggling with the enforcement of PEP668 on bookworm). |
Should be good for now. I have some further ideas but that would be another PR. |
Merged
AlvinSchiller
added a commit
to AlvinSchiller/RPi-Jukebox-RFID
that referenced
this pull request
Dec 21, 2023
* removed obsolete v3.x workflow files * set user and group as build args to test altuser removed now obsolete "*_altuser" Dockerfile * set GIT_BRANCH and GIT_URL as build args makes sure that the installation script uses the current repo/branch * use correct variables for refname resolving * harmonized workflow and Dockerfiles * optimize test docker performance. copy changed only include the scripts that are needed. Otherwise every code change will invalidate the container cache. changed internal path of container and test scripts * optimize test docker performance. refactored changed thestructure to use the cache as much as possible. repo url -> packages -> user -> scripts * changed cache key with ref instead of ref_name pull request will get a different cache * get username with whoami to be compatible with containers * implemented different strategies for uniformity * set noninteractive on debconf get rid of warning "debconf: unable to initialize frontend: Dialog" export DEBIAN_FRONTEND=noninteractive does not work with sudo * unified workflow for debian. delete obsolete files * fix branch name on pr * refactored into subworkflow * fixed apt-key deprecation * unified Dockerfile. renamed workflow files * fix repo name on pullrequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test executions are currently running sequentially and build the docker image multiple times. Also the cache is not used, as the code base is included as one of the first layer, so a change in the repo triggers an entire rebuild of the image.
Furthermore are the files mostly duplicates and hard to maintain.
Included Changes:
Dockerfiles
--build-args="DEBIAN_VERSION_NAME=xxx"
--platform=linux/arm/v7
--user=xxx
from caller)Workflows
Additional changes
apt-key
usageexport DEBIAN_FRONTEND=noninteractive
not working with sudo apt-get ... )whoami
rather then$USER
to have higher compatibility with containersInformation about the caching