-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make changes for Raspberry Pi OS Bookworm #2084
Conversation
* use venv as Bookworm implemented PEP668 * explicitly install netcat-traditional package
The enforcement of PEP668 seems not so easy to solve, right now I'm not sure whats the best way for us. Some references:
|
Some more opinions on PEP 668: raspberrypi/bookworm-feedback#100 |
Do you have trouble using Python in venv? |
It's more my lack of knowledge of venvs, so far I avoided them pretty successful ;) @pabera, maybe you can have a look at the changes I tried in this PR - I'm pretty sure that it's solvable, but I don't have enough experience with venvs to choose the best solution for us. |
I would try a bit too if i have time, but i have also not much experience with python and venvs.
|
It would be a very idealistic approach to solve this for V2, I agree with @AlvinSchiller. But because we rely on Python a lot more in V3, this could be a heavy lift. |
I also think for legacy 2.x |
…worm_adaptation # Conflicts: # scripts/installscripts/buster-install-default-with-autohotspot.sh
Pull Request Test Coverage Report for Build 6804281312Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Hey @s-martin, see: https://github.com/AlvinSchiller/RPi-Jukebox-RFID/tree/test/bookworm |
You probably mean the check for package 532 and 522? I fixed them in #2092 |
Spotify packages seem not to be available for Bookworm:
|
The "MPDConfig" block need to be moved ahead of "SPOTInstall" so the mpd service enablement is correct in the end. |
I fixed it by explicitly stopping and disabling mpd, when Spotify is used. |
Yep but Spotifyinstall and mpdconfig are not mutually exclusive. So the Spotify block will disable mpd service and the mpd block after will enable it again, which is not a correct state. |
Sorry if I'm bringing this up here: it sounds that (usage of) |
* fixed markdown warnings * fix flake warnings * * use bookworm * use venv as Bookworm implemented PEP668 * explicitly install netcat-traditional package * dont sudo activate * allow breaking system packages * fix break-system-packages, as this switch doesnt exist pre bookworm * improve command for break system packages * set break system packages globally * fix permissions for mpd.conf * revert last commit * explictily start mpd * explicitly stop mod when using Spotify * use parallel for coveralls
Make changes so Phoniebox 2.x runs on Bookworm (this PR replaces #2080)
Changes:
TODOs:
Configuring MPD... MPD error: Cannot assign requested address
there is also a check missing for test 2 --> will be fixed in Further Optimizations #2092
should be fixed by Implemented fixes for RPi recognition and new spotify GST plugin compile #2064