Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename install script to "install-jukebox.sh" #2110

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

AlvinSchiller
Copy link
Collaborator

Best to merge right before 2.5 release to not interfere other open PRs.


Changes in Wiki: https://github.com/AlvinSchiller/RPi-Jukebox-RFID.wiki.git
To merge the changes in the wiki repo:

a. Simple commandline:

b. To Merge with a prefered tool (like VS Code, ...):

  • clone the original wiki from: https://github.com/MiczFlor/RPi-Jukebox-RFID.wiki.git
  • add my wiki repo as a new remote 'AlvinSchiller': git remote add AlvinSchiller https://github.com/AlvinSchiller/RPi-Jukebox-RFID.wiki.git
  • git fetch --all
  • use the tool to pull / merge / rebase the changes from my wiki repo master branch
  • push to "origin"

@coveralls
Copy link

coveralls commented Nov 14, 2023

Pull Request Test Coverage Report for Build 6863227340

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.82%

Totals Coverage Status
Change from base Build 6807782428: 0.0%
Covered Lines: 633
Relevant Lines: 824

💛 - Coveralls

@s-martin
Copy link
Collaborator

Keine Vorkommnisse in den markdown files?

@AlvinSchiller
Copy link
Collaborator Author

Keine Vorkommnisse in den markdown files?

Im Repo nur bug_template.md und ci/README.md, mehr nicht. Einige sind ja auch mit #2008 entfallen oder schon bereinigt worden

@Groovylein
Copy link
Collaborator

Bookworm checks sind nicht durchgelaufen, aber ich gehe davon aus das das ok ist?!

@s-martin
Copy link
Collaborator

Bookworm checks sind nicht durchgelaufen, aber ich gehe davon aus das das ok ist?!

Ja, das wird erst mit #2064 gefixt.

@s-martin s-martin merged commit 54ee74d into MiczFlor:develop Nov 14, 2023
33 of 34 checks passed
@AlvinSchiller AlvinSchiller deleted the feature/renameInstallscript branch November 14, 2023 15:07
AlvinSchiller added a commit to AlvinSchiller/RPi-Jukebox-RFID that referenced this pull request Dec 21, 2023
* rename install script to "install-jukebox.sh"

* further changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants