Add NFCPy support

[powertomato]

This Pull Request adds support for using NFCPy supported NFC readers

[s-martin]

Thanks for your addition! 🙏🎉
Nice work! 👍

I made a few comments to ensure that this new rfid reader is integrated properly.

[Groovylein]

Except for the points that @s-martin found, I like the changes you did there!

Which device did you test on?

[powertomato]

Except for the points that @s-martin found, I like the changes you did there!

Which device did you test on?

I tested on a Rock64 with dietpi. As for the NFC reader it's an ACR122U

[s-martin]

Thanks for the updates!

[pabera]

I am unable to check this since I don't have a matching device available. Have you tested your set up properly? Was the installation process smooth. Since you followed the guidance, I'd suggest to merge this. Maybe you could resolve the above comments and send this for code review again. I have added this to the next release #2211.

[powertomato]

I am unable to check this since I don't have a matching device available. Have you tested your set up properly? Was the installation process smooth. Since you followed the guidance, I'd suggest to merge this. Maybe you could resolve the above comments and send this for code review again. I have added this to the next release #2211.

This is tested, but I wanted to resolve the comments first and do a complete clean install again to confirm. I'm sick since a week, and will probably not come around that before the end of the week.

[powertomato]

I have improved the installation script and customization by scanning for compatible devices and letting the user choose which one they want to use. It is very similar to the generic_usb RFID module.

The customization code will also generate an explicit device path, that will also allow to use multiple NFCpy compatible devices at the same time.

Edit: I just came accross git update-index --chmod=+x, now it works, the text below is outdated.

The code is tested on a fresh installation and works beside one small quirk, which I seemingly cannot fix.

The file src/jukebox/components/rfid/hardware/generic_nfcpy/setup.inc.sh is missing execution rights when checked out. The file is executable on my machine, but I suspect it has something to do, that I committed it on a windows machine...

When I add the execution rights and rerun run_register_rfid_reader.py everything works flawlessly.

[coveralls]

Pull Request Test Coverage Report for Build 7768616291

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 38.384%

---

Totals
Change from base Build 7646903644:	0.0%
Covered Lines:	418
Relevant Lines:	1089

---

💛 - Coveralls

[s-martin]

@powertomato it looks like you are finished and as you said you tested it we approved it.

If you have no more changes planned, we would merge it.

[s-martin]

Just stumbled over this code line:

RPi-Jukebox-RFID/src/jukebox/components/rfid/configure/__init__.py

Line 154 in 2bb9367

included_readers = [NO_RFID_READER, 'generic_usb', 'rdm6300_serial', 'rc522_spi', 'pn532_i2c_py532', 'fake_reader_gui']

@pabera, @AlvinSchiller do we need to add nfcpy there?

[AlvinSchiller]

Just stumbled over this code line:

RPi-Jukebox-RFID/src/jukebox/components/rfid/configure/__init__.py

Line 154 in 2bb9367

included_readers = [NO_RFID_READER, 'generic_usb', 'rdm6300_serial', 'rc522_spi', 'pn532_i2c_py532', 'fake_reader_gui']

@pabera, @AlvinSchiller do we need to add nfcpy there?

No, its not necessary. The nfcpy will be picked up as additional reader and is appended.
We could add it to get it in a different order.

[AlvinSchiller]

Nice work. Thanks again!