Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs #2216
Update docs #2216
Changes from 13 commits
041188d
1849ed0
4ec0e66
3f71c47
d1800b5
30713b4
dcd33ae
da0e7c7
ce9930f
b933f17
c60d439
ff8fb3d
22731c6
4f2605e
1b39e9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok to add all components here, or do we need to split this for hardware and software implementations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability, I would split that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as this list grows, we can slit it. I like the idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about splitting it now and restructure a bit.
In my opinion its not really clear what the different headers mean (config, components, advanced).
Idea for restructuring:
Additionally i would suggest to add the rfid reader docs for supported readers. Maybe even move to builder space (except mock and template)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we refer to use Bullseye, this is not a problem anymore.
Meanwhile, can't we just automate this instead of describing it here, potentially loosing builders along the way? We could silently change the raspi-config in the installation, most builders won't care. It's a save convention to define.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could keep this docs for reference on Bookworm, but it'll be less of a pain for most builders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our current installation instruction dont mention a specific version (the default will be select be RPI Imager), but i think more and more will use the newer Bookworm, and running into this.
A quickfix in the installation is not possible, as a change of the setting will instantly reset the network and the user will lose access to the device, if it has a wifi connection.
I address the problem, with #2184 to have both ways working.
So this is just a temporary documentation apart from the Issue and notes in the Release till the implementation is finished ( in case it will not be ready for 3.5.0 ).