NetworkManager Support #2218
NetworkManager Support #2218
Conversation
add seperate daemon service for wpa-supplicant handling
fix ipv6 disablement
|
IPv6 disablement was also broken for bullseye. |
| echo -n ${string} | wc -m | ||
| } | ||
|
|
||
| is_service_enabled() { |
There was a problem hiding this comment.
There is quite some similarity with verify_service_enablement(). Could those 2 functions be combined?
There was a problem hiding this comment.
Done. Extracted the repetitive code to an internal function
| local configFile=$(get_boot_config_path) | ||
| log " Disable on-chip BCM audio" | ||
| if grep -q -E "^dtparam=([^,]*,)*audio=(on|true|yes|1).*" "${RPI_BOOT_CONFIG_FILE}" ; then | ||
| log " Backup ${RPI_BOOT_CONFIG_FILE} --> ${DISABLE_ONBOARD_AUDIO_BACKUP}" | ||
| sudo cp "${RPI_BOOT_CONFIG_FILE}" "${DISABLE_ONBOARD_AUDIO_BACKUP}" | ||
| sudo sed -i "s/^\(dtparam=\([^,]*,\)*\)audio=\(on\|true\|yes\|1\)\(.*\)/\1audio=off\4/g" "${RPI_BOOT_CONFIG_FILE}" | ||
| if grep -q -E "^dtparam=([^,]*,)*audio=(on|true|yes|1).*" "${configFile}" ; then | ||
| local configFile_backup="${configFile}.backup.audio_on_$(date +%d.%m.%y_%H.%M.%S)" | ||
| log " Backup ${configFile} --> ${configFile_backup}" | ||
| sudo cp "${configFile}" "${configFile_backup}" | ||
| sudo sed -i "s/^\(dtparam=\([^,]*,\)*\)audio=\(on\|true\|yes\|1\)\(.*\)/\1audio=off\4/g" "${configFile}" | ||
| else | ||
| log " On board audio seems to be off already. Not touching ${RPI_BOOT_CONFIG_FILE}" | ||
| log " On board audio seems to be off already. Not touching ${configFile}" |
There was a problem hiding this comment.
This is not related to NetworkManager. Since I already worked on this in my PR, maybe you could remove it to avoid conflicts
There was a problem hiding this comment.
Can do, but this leaves this feature not functional for bookworm and some clutter.
It should also not be a problem with your branch, as you deleted the whole file, which can just be kept on merging.
I can support on merging if you like.
Aligned some language and typos
Aligning wording and removing typos
PR for #2184
Optional (maybe with a seperat PR)