Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce MPD setup during installation #2309

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

AlvinSchiller
Copy link
Collaborator

@AlvinSchiller AlvinSchiller commented Mar 27, 2024

Following the report of #2306:

  • The user option for MPD setup is removed. Instead the mpd.conf is always deployed, as Phoniebo is not functionally otherwise. The manual process to fix this is not straight forward and error prone.
  • Multiple sample conf files existed in the repo. This was cleaned to only have one left used by the setup.

TODO:

  • manual installation tests on device

@AlvinSchiller AlvinSchiller added bug installation legacy_v2 Issues, discussions and PRs related to Version 2.x labels Mar 27, 2024
@AlvinSchiller AlvinSchiller added this to the v2.6 milestone Mar 27, 2024
@AlvinSchiller AlvinSchiller self-assigned this Mar 27, 2024
@AlvinSchiller
Copy link
Collaborator Author

AlvinSchiller commented Mar 27, 2024

@s-martin
Additional change suggestion (already checked in but can be reverted):

  • Currently the spotify installation defaults to "yes". As spotify is not working for some time now, without user changes, the default should be changed to "no", having the "classic" edition as default.

@coveralls
Copy link

coveralls commented Mar 27, 2024

Pull Request Test Coverage Report for Build 8452689755

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.435%

Totals Coverage Status
Change from base Build 8416480811: 0.0%
Covered Lines: 451
Relevant Lines: 575

💛 - Coveralls

@s-martin
Copy link
Collaborator

@s-martin
Additional change suggestion (already checked in but can be reverted):

  • Currently the spotify installation defaults to "yes". As spotify is not working for some time now, without user changes, the default should be changed to "no", having the "classic" edition as default.

Yes!

@AlvinSchiller AlvinSchiller mentioned this pull request Mar 27, 2024
1 task
@AlvinSchiller AlvinSchiller marked this pull request as ready for review March 27, 2024 14:32
@AlvinSchiller AlvinSchiller merged commit 5bd19aa into MiczFlor:develop Mar 28, 2024
36 of 37 checks passed
@AlvinSchiller AlvinSchiller deleted the fix/setup-mpd-conf branch March 28, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug installation legacy_v2 Issues, discussions and PRs related to Version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants