-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation fixes and refactoring #2350
Merged
AlvinSchiller
merged 11 commits into
MiczFlor:develop
from
AlvinSchiller:fix/fixes-and-refactoring
Apr 23, 2024
Merged
Installation fixes and refactoring #2350
AlvinSchiller
merged 11 commits into
MiczFlor:develop
from
AlvinSchiller:fix/fixes-and-refactoring
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AlvinSchiller
commented
Apr 19, 2024
- moved some logoutputs to be contained in logfile for better researchability
- refactored finish routine, seperated rfid setup
- removed "repace homedir" logic -> v2 will not be refactored to be used with a different user
- fix special char handling in install conf file through escaping
- harmonized install conf var writeout
- update testdata for special chars
extracted rfid_reader setup
v2 will not be refactored to be used with a different user
AlvinSchiller
added
enhancement
installation
legacy_v2
Issues, discussions and PRs related to Version 2.x
labels
Apr 19, 2024
Pull Request Test Coverage Report for Build 8759564735Details
💛 - Coveralls |
The escaping for the wifi values also needs to be done from the WebApp. |
s-martin
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.