Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket #3748: add support for ksh in subshell #209

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

d3m3t3r
Copy link

@d3m3t3r d3m3t3r commented Nov 7, 2024

Support Korn shell variants (ksh/oksh/mksh) in the subshell.

Thank you for thinking about contributing to Midnight Commander, but we ARE NOT using pull requests to manage incoming patches!

Instead, please check out our Trac instance to see if the issue has already been reported, or submit a new ticket:

https://midnight-commander.org/wiki/NewTicket

If you chose to submit the pull request instead, keep in mind that we are not checking on them regularly, so it might take ages before we even get to it, if at all.

Unfortunately, GitHub does not allow us to disable the pull requests feature for this repository, so we have to warn you this way...

Support Korn shell variants (ksh/oksh/mksh) in the subshell.
mksh (MirBSD Korn shell) is handled separately as it substantially
differs from pdksh (Public Domain Korn shell) based varaints.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what exactly are BASH, ASH and SH environment variables for in mc_shell_recognize_path(). They are not defined by corresponding shells.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement "... Midnight Commander will spawn a concurrent copy of your shell (the one defined in the SHELL variable and if it is not defined, then the one in the /etc/passwd file) ..." is not correct as /etc/passwd (~ getpwuid()) is not used in mc_shell_init() to detect shell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant