Skip to content
This repository has been archived by the owner on Jan 21, 2023. It is now read-only.

Support adding animations to static views #80

Open
1 task done
yt-ms opened this issue May 12, 2021 · 1 comment
Open
1 task done

Support adding animations to static views #80

yt-ms opened this issue May 12, 2021 · 1 comment

Comments

@yt-ms
Copy link
Collaborator

yt-ms commented May 12, 2021

Checklist

Is your feature related to a problem? Please describe it.

Following PR #77, the last remaining part of the API needed to complete the big_bank.py example is being able to add animations to static views.

Describe the solution you would like.

Mirroring the Java implementation,, we should add an add_animation() method to StaticView which accepts a variable number of elements, and copy the logic from Java. The serialisation and deserialisation of animation data has already been done, so it's just about being able to add animations programmatically.

    system_landscape_view.add_animation(internet_banking_system, customer, mainframe_banking_system, emailSystem)
    system_landscape_view.add_animation(atm)
    system_landscape_view.add_animation(customerServiceStaff, back_office_staff)
@yt-ms
Copy link
Collaborator Author

yt-ms commented May 12, 2021

Given animations also are supported in the (currently experimental) CustomView in Java which doesn't extend StaticView, then perhaps this should be implemented in Python as a mixin (both View and IO) which can be used by both.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant