Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add permisions precondition #16211

Draft
wants to merge 69 commits into
base: develop
Choose a base branch
from
Draft

add permisions precondition #16211

wants to merge 69 commits into from

Conversation

Geometer1729
Copy link
Member

@Geometer1729 Geometer1729 commented Oct 10, 2024 •
edited
Loading

Explain your changes:

  • Adds a permissions field to the account update preconditions

Explain how you tested your changes:

  • currently only limited testing through o1js

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@Geometer1729 Geometer1729 self-assigned this Oct 10, 2024
@Geometer1729 Geometer1729 changed the title Brian/permisions precondition add permisions precondition Oct 10, 2024
@Geometer1729 Geometer1729 mentioned this pull request Oct 10, 2024
Open
@Geometer1729
Copy link
Member Author

!ci-nix-me

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729
Copy link
Member Author

!ci-build-me

mrmr1993
mrmr1993 reviewed Dec 4, 2024
View reviewed changes
src/lib/mina_base/test/zero_vesting_period.ml Outdated
"set_token_symbol": [ "Ignore" ],
"increment_nonce": [ "Ignore" ],
"set_voting_for": [ "Ignore" ],
"set_timing": [ "Ignore" ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This trailing comma is not valid JSON.

src/lib/mina_base/test/zero_vesting_period.ml Outdated
"set_token_symbol": [ "Ignore" ],
"increment_nonce": [ "Ignore" ],
"set_voting_for": [ "Ignore" ],
"set_timing": [ "Ignore" ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here

mrmr1993
mrmr1993 reviewed Dec 4, 2024
View reviewed changes
src/lib/mina_base/test/zero_vesting_period.ml Outdated
@@ -138,6 +138,21 @@ let mk_zkapp_with_vesting_period n =
"proved_state": [ "Ignore" ],
"is_new": [ "Ignore" ]
},
"permissions": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems to be in the wrong place, it should be in account above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that, I moved the permissions inside account field elsewhere but forgot to move it here. It seems like that was causing the flaky proof cache issue.

src/lib/mina_base/test/zero_vesting_period.ml Outdated
@@ -246,6 +261,21 @@ let mk_zkapp_with_vesting_period n =
"proved_state": [ "Ignore" ],
"is_new": [ "Ignore" ]
},
"permissions": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729 Geometer1729 deleted the brian/permisions-precondition branch December 11, 2024 14:20
@Geometer1729 Geometer1729 restored the brian/permisions-precondition branch December 11, 2024 14:21
@Geometer1729 Geometer1729 reopened this Dec 11, 2024
@Geometer1729
Copy link
Member Author

sorry closed the wrong pr

@Geometer1729
Copy link
Member Author

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Geometer1729 Geometer1729

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permission preconditions
2 participants
@Geometer1729 @mrmr1993