Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new public method to allow sending simple strings #122

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

TheRealAgentK
Copy link
Contributor

@TheRealAgentK TheRealAgentK commented Oct 11, 2024

#81 feat: new public method to allow sending simple strings

Description 📝

Adds a new public variation of the send method where simple strings for message/exception name and reason can be passed in. This mimics a feature in the iOS provider. Fixes #81.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Updates

👉 new send() method
👉 documentation update
👉 hooked into sample app

Author to check 👓

  • Project and all contained modules build
  • Tested on appropriate devices/emulators and SDK versions
  • Reviewed by another developer
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Change has been tested on a device/emulator
  • Code is written to standards
  • Appropriate tests have been written (code comments, internal docs)

@TheRealAgentK TheRealAgentK changed the title feature: new public method to allow sending simple strings feat: new public method to allow sending simple strings Oct 11, 2024
@TheRealAgentK TheRealAgentK merged commit ad51374 into develop Oct 13, 2024
3 of 4 checks passed
@TheRealAgentK TheRealAgentK deleted the feature/#81-newSendSignature branch October 13, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a send method with message and classname to be set
2 participants