Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Setup eslint and fix issues (WIP) #155

Closed
wants to merge 20 commits into from

Conversation

miquelbeltran
Copy link
Contributor

Description 📝

Setup eslint in the project, including applying static analysis and formatting.

Draft to check how GitHub Actions is responding to it.

Type of change

  • New feature (non-breaking change which adds functionality)

Updates

  • Setup eslint in the project.
  • Remove tslint dependencies.
  • Setup the npm run eslint command.
  • Setup GitHub Actions to run npm run eslint as part of the PR.

Test plan 🧪

  • code tests should still run and pass
  • npm run eslint should return no warnings
  • run the examples in the examples folder

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@miquelbeltran miquelbeltran deleted the setup-eslint branch May 8, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant