refactor: #158 remove no-explicit-any ignore eslint rule #159

miquelbeltran · 2024-04-25T08:51:57Z

refactor: #58 remove `no-explicit-any` ignore from eslint rule.

Description 📝

Removes the no-explicit-any rule from the eslint configuration, applies code changes.
Part of eslint: remove ignored rules and fix issues #158
Depends on Replace tslint usage with eslint. #145

Type of change

tech debt

Updates

Removed ignored rule from config file.
set specific type for timerId instead of any.
improve filterKeys internal function.
improve setErrorDetails public function, still allow any for end users.
improve IndexableError type.
improve worker callback type, even if the parameter is not used.
allow any as CustomData so end users can provide whatever data they want.

Test plan 🧪

Run the npm ci, npm test and npm run eslint commands to ensure no issues raised.
Verified that there were test cases using those changed functions.
Run examples.

Author to check 👓

Project and all contained modules builds successfully
Self-/dev-tested
Unit/UI/Automation/Integration tests provided where applicable
Code is written to standards
Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

Project and all contained modules builds successfully
Change has been dev-/reviewer-tested, where possible
Unit/UI/Automation/Integration tests provided where applicable
Code is written to standards
Appropriate documentation written (code comments, internal docs)

…y from the end users

miquelbeltran · 2024-04-25T09:07:10Z

PR is set to "into 145-eslint-setup" temporarily, the idea is to set to develop once #156 is merged

lib/raygun.sync.worker.ts

examples/express-sample/package-lock.json

sumitramanga

A couple of comments to look into before I approve!

Co-authored-by: Sumitra Manga <[email protected]>

sumitramanga

LGTM! 🧇

* removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * update package lock in sample * Update lib/raygun.sync.worker.ts Co-authored-by: Sumitra Manga <[email protected]> * remove empty line --------- Co-authored-by: Sumitra Manga <[email protected]>

@sumitramanga

* ci: Create node.js.yml (#142) * ci: Create node.js.yml * Include "develop" in the branch list to run CI actions * trigger GitHub actions. * fix: Updating dependencies and fixes (#144) * chore: updated dependencies * chore: update to tslint-react 5.0.0 * fix: mixup between Request and RequestParams * fix: convert Express Request to RequestParams * fix: recreate package-lock to fix express dependency errors * fix: test tap command update * fix: test asserts * refactor: use equal instead of ok * Adding PR, bug report and feature request templates. * Update pull_request_template.md Committing @sumitramanga's suggestion Co-authored-by: Sumitra Manga <[email protected]> * Update .github/bug_report.md Nice! Co-authored-by: Sumitra Manga <[email protected]> * Update .github/bug_report.md Co-authored-by: Sumitra Manga <[email protected]> * ci: #145 eslint setup (#156) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * chore: #148 upgrade examples (#157) * express example: upgrade dependencies and point to subfolder raygun package * using-domains: upgrade dependencies and reference local raygun * using-domains: upgrade dependencies and reference local raygun * add console logs and format using spaces * improved readme * improved readme + replace tabs by spaces * enforce changing API keys to run examples * ci: add PR title checks (#167) * ci: Update dependabot.yml (#168) * chore(deps): bump actions/checkout from 3 to 4 (#171) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/setup-node from 3 to 4 (#172) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Move pr.yml to workflows (#175) * refactor: #158 remove no-explicit-any ignore eslint rule (#159) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * update package lock in sample * Update lib/raygun.sync.worker.ts Co-authored-by: Sumitra Manga <[email protected]> * remove empty line --------- Co-authored-by: Sumitra Manga <[email protected]> * refactor: #158 remove no-this-alias ignore eslint rule (#160) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * update package lock in sample * refactor: #158 fix eslint rule "no-unused-vars" (#170) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * ci: #174 Prettier setup (#169) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * add examples to prettier command * add prettier job to node js ci job * script fix * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * config files * run npm run prettier * Update .github/workflows/node.js.yml Co-authored-by: Sumitra Manga <[email protected]> * fix workflow * add comments to the package.json * add missing files * remove fetch-depth: 0 --------- Co-authored-by: Sumitra Manga <[email protected]> * chore: #158 document why no-var-requires ignore is necessary (#173) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * add examples to prettier command * add prettier job to node js ci job * script fix * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * config files * run npm run prettier * chore: document why no-var-requires ignore is necessary update comment * refactor: #158 configure no-undef eslint rule (#176) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * add examples to prettier command * add prettier job to node js ci job * script fix * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * config files * run npm run prettier * chore: document why no-var-requires ignore is necessary update comment * fix: #158 configure no-undef eslint rule * refactor: #158 configure no-unreachable eslint rule (#177) * refactor: #158 remove no-useless-catch eslint rule (#178) * refactor: #158 configure no-unreachable eslint rule * refactor: #158 remove no-useless-catch eslint rule * chore: Prepare for Release 0.14.0 (#179) * refactor: #158 configure no-unreachable eslint rule * refactor: #158 remove no-useless-catch eslint rule * set version 0.14.0 * update changelog * Update package.json Co-authored-by: Sumitra Manga <[email protected]> * add Error reporting to keywords * update license copyright year * updated URL * added more keywords * moar keywords --------- Co-authored-by: Sumitra Manga <[email protected]> * chore: Update package-lock.json (#180) * chore: update package-lock.json (#183) * chore: change author name (#185) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kai Koenig <[email protected]> Co-authored-by: Sumitra Manga <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

miquelbeltran added 15 commits April 24, 2024 09:33

removed tslint

1b86912

add eslint

2594236

add default config

0a8f09d

setup default config and npm run command

e05676e

add command to node.js.yml

efb470f

set rules to support current codebase

930758a

remove unused tslint.json

7c144e1

include sample files in eslint command

81e4cae

remove rule no-explicit-any

c7bdcc7

specify type for timer

abdd156

remove any from filterKeys

44adb8f

explictly declare that error can be Error, String but still accept an…

284f95b

…y from the end users

specify types in the sync worker

28c3bbf

improve the IndexableError type

a0df356

explain why any is allowed in CustomData

57cffc7

miquelbeltran mentioned this pull request Apr 25, 2024

refactor: #158 remove no-this-alias ignore eslint rule #160

Merged

11 tasks

Base automatically changed from 145-eslint-setup to develop April 29, 2024 05:32

Merge branch 'develop' into 158-eslint-fixes

68c932b

miquelbeltran marked this pull request as ready for review April 29, 2024 05:53

update package lock in sample

5ad42ce

miquelbeltran requested review from sumitramanga and TheRealAgentK April 29, 2024 07:21

sumitramanga reviewed Apr 29, 2024

View reviewed changes

lib/raygun.sync.worker.ts Outdated Show resolved Hide resolved

sumitramanga reviewed Apr 29, 2024

View reviewed changes

examples/express-sample/package-lock.json Outdated Show resolved Hide resolved

sumitramanga reviewed Apr 29, 2024

View reviewed changes

Update lib/raygun.sync.worker.ts

d81f67c

Co-authored-by: Sumitra Manga <[email protected]>

miquelbeltran requested a review from sumitramanga April 30, 2024 05:35

remove empty line

4c93d62

sumitramanga approved these changes Apr 30, 2024

View reviewed changes

miquelbeltran merged commit de0eed9 into develop May 1, 2024
4 checks passed

miquelbeltran deleted the 158-eslint-fixes branch May 1, 2024 05:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: #158 remove no-explicit-any ignore eslint rule #159

refactor: #158 remove no-explicit-any ignore eslint rule #159

miquelbeltran commented Apr 25, 2024 •

edited by sumitramanga

Loading

miquelbeltran commented Apr 25, 2024

sumitramanga left a comment

sumitramanga left a comment

refactor: #158 remove no-explicit-any ignore eslint rule #159

refactor: #158 remove no-explicit-any ignore eslint rule #159

Conversation

miquelbeltran commented Apr 25, 2024 • edited by sumitramanga Loading

refactor: #58 remove no-explicit-any ignore from eslint rule.

Description 📝

Test plan 🧪

Author to check 👓

Reviewer to check ✔️

miquelbeltran commented Apr 25, 2024

sumitramanga left a comment

Choose a reason for hiding this comment

sumitramanga left a comment

Choose a reason for hiding this comment

miquelbeltran commented Apr 25, 2024 •

edited by sumitramanga

Loading

refactor: #58 remove `no-explicit-any` ignore from eslint rule.