Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: #192 Express sample app documentation improvements and renames to README.md #193

Merged
merged 1 commit into from
May 6, 2024

Conversation

TheRealAgentK
Copy link
Contributor

docs: #192 (Express sample app documentation improvements and renames to README.md)

Description 📝

Type of change

  • This change requires a documentation update (in fact it IS a documentation update only)

Updates

👉 Changed content of express sample README
👉 Renamed all other sample readme files to README to make it consistent with main project

Test plan 🧪

n/a

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@TheRealAgentK TheRealAgentK requested review from a team, miquelbeltran, PanosNB and sumitramanga and removed request for a team May 6, 2024 09:04
Copy link
Collaborator

@sumitramanga sumitramanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@TheRealAgentK TheRealAgentK merged commit 7956869 into develop May 6, 2024
5 checks passed
@TheRealAgentK TheRealAgentK deleted the feature/#192-sampleREADME branch May 6, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Express sample README improvements
3 participants