-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Version 1.0.0 #233
chore: Version 1.0.0 #233
Changes from all commits
d8ec309
f4ae131
e14deec
61a9539
fc09498
641bb4c
a95d14c
57ceec3
77b8229
ed8aee9
c322f01
a80e8dd
9ebcc4e
d147888
3fb1482
8e37c10
f5c1307
188d9c9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,29 @@ | ||
## 1.0.0 | ||
|
||
- feat: #219 Better Send parameters (#221) (2024-05-17) | ||
- feat: Breadcrumbs (#210) (2024-05-15) | ||
- fix: #138 New APM Bridge Setup (#222) (2024-05-20) | ||
- docs: Update status badge in README.md (#209) (2024-05-10) | ||
- refactor: #205 Setup eslint style (#207) (2024-05-09) | ||
- refactor: #197 Refactor to use Promises internally (#200) (2024-05-09) | ||
- refactor: #184 Cleanup debug/log messages and styles (#194) (2024-05-08) | ||
- chore(deps-dev): bump typescript-eslint from 7.8.0 to 7.9.0 (#229) (2024-05-20) | ||
- chore(deps-dev): bump @eslint/js from 9.2.0 to 9.3.0 (#228) (2024-05-20) | ||
- chore(deps-dev): bump @types/node from 20.12.11 to 20.12.12 (#227) (2024-05-20) | ||
- chore(deps-dev): bump @stylistic/eslint-plugin from 2.0.0 to 2.1.0 (#214) (2024-05-13) | ||
- chore(deps-dev): bump tap from 18.7.2 to 18.8.0 (#213) (2024-05-13) | ||
- chore(deps-dev): bump @types/node from 20.12.8 to 20.12.11 (#212) (2024-05-13) | ||
- chore(deps-dev): bump semver from 7.6.0 to 7.6.2 (#211) (2024-05-13) | ||
- chore: code cleanup (#225) (2024-05-20) | ||
- chore: apply prettier to all files in examples (#226) (2024-05-19) | ||
|
||
**BREAKING CHANGES** | ||
|
||
- `send()` method signature changed. | ||
- APM Bridge setup process changed. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What were we doing before and as above, can we support a deprecated version? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The previous setup process was causing compilation errors to some users and was not possible to properly unit test it, it is explained in detail here: #222 |
||
|
||
See README.md for more information. | ||
|
||
## 0.15.0-0 | ||
- async/await `send()` support | ||
- Upgrade dependencies | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,16 +4,16 @@ | |
* Module dependencies. | ||
*/ | ||
|
||
var app = require('../app'); | ||
var debug = require('debug')('express-sample:server'); | ||
var http = require('http'); | ||
var app = require("../app"); | ||
var debug = require("debug")("express-sample:server"); | ||
var http = require("http"); | ||
|
||
/** | ||
* Get port from environment and store in Express. | ||
*/ | ||
|
||
var port = normalizePort(process.env.PORT || '3000'); | ||
app.set('port', port); | ||
var port = normalizePort(process.env.PORT || "3000"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if the user does not use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because this is an example app, we should not have to worry about this? 🤔 We are using the standard way to set up ports I would think. Happy to be challenged! Such as, what other way would people use commonly :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Yes, agreed with @sumitramanga I guess this is standard express: |
||
app.set("port", port); | ||
|
||
/** | ||
* Create HTTP server. | ||
|
@@ -26,8 +26,8 @@ var server = http.createServer(app); | |
*/ | ||
|
||
server.listen(port); | ||
server.on('error', onError); | ||
server.on('listening', onListening); | ||
server.on("error", onError); | ||
server.on("listening", onListening); | ||
|
||
/** | ||
* Normalize a port into a number, string, or false. | ||
|
@@ -54,22 +54,26 @@ function normalizePort(val) { | |
*/ | ||
|
||
function onError(error) { | ||
if (error.syscall !== 'listen') { | ||
if (error.syscall !== "listen") { | ||
throw error; | ||
} | ||
|
||
var bind = typeof port === 'string' | ||
? 'Pipe ' + port | ||
: 'Port ' + port | ||
var bind = typeof port === "string" ? "Pipe " + port : "Port " + port; | ||
|
||
// handle specific listen errors with friendly messages | ||
switch (error.code) { | ||
case 'EACCES': | ||
console.error(`[Raygun4Node-Express-Sample] ` + bind + ` requires elevated privileges`); | ||
case "EACCES": | ||
console.error( | ||
`[Raygun4Node-Express-Sample] ` + | ||
bind + | ||
` requires elevated privileges`, | ||
); | ||
process.exit(1); | ||
break; | ||
case 'EADDRINUSE': | ||
console.error(`[Raygun4Node-Express-Sample] ` + bind + ` is already in use`); | ||
case "EADDRINUSE": | ||
console.error( | ||
`[Raygun4Node-Express-Sample] ` + bind + ` is already in use`, | ||
); | ||
process.exit(1); | ||
break; | ||
default: | ||
|
@@ -83,8 +87,6 @@ function onError(error) { | |
|
||
function onListening() { | ||
var addr = server.address(); | ||
var bind = typeof addr === 'string' | ||
? 'pipe ' + addr | ||
: 'port ' + addr.port; | ||
debug('Listening on ' + bind); | ||
var bind = typeof addr === "string" ? "pipe " + addr : "port " + addr.port; | ||
debug("Listening on " + bind); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"Raygun": { | ||
"Key": "YOUR_API_KEY" | ||
} | ||
} | ||
"Raygun": { | ||
"Key": "YOUR_API_KEY" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we support a backwards-compatible but deprecated (and to be removed next)
send
method? With some additional checking logic, it could as simple asfunction send(error, customData={}, request,={} tags={}){ return send(error, {customData: customData, request: request, tags: tags});}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it makes sense to add in the deprecation, we could do this now whilst we discuss the final decision. It looks like we've done something in the past about deprecating (which we may need to remove -
raygun4node/lib/raygun.ts
Line 159 in 8e37c10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We provide a backwards compatible method, is
sendWithCallback()
.raygun4node/lib/raygun.ts
Lines 292 to 318 in 8e37c10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JavaScript doesn't support overloading methods. There ware some workarounds but have limitations.