Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies; explicitly set UTF-8 encoding #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

itsTyrion
Copy link

Did a quick test, everything seems to work so far.
explicitly set UTF-8 encoding because I was getting an "illegal character" error at the section symbol (§) during build.

The Log4J2 version in HEAD/master is vulnerable to Log4shell btw !!

@itsTyrion
Copy link
Author

itsTyrion commented Nov 18, 2023

One more thing:

I spent about an hour turning in circles because I didn't know that the Log4j2 plugin cache (Log4j2Plugins.dat) needs to be merged, I was unable to get it to work without it (aside from the deprecated package= property in log4j2.xml)

For Gradle, there's a transformer in shadow

shadowJar { 
    transform(com.github.jengelman.gradle.plugins.shadow.transformers.Log4j2PluginsCacheFileTransformer)
}

For maven, Apache took over what used to be a 3rd party plugin: https://logging.apache.org/log4j/transform/latest/#log4j-plugin-cache-transformer

Should I add that a hint about it to the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant