Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU and GPU fan speed #36

Closed
wants to merge 1 commit into from
Closed

CPU and GPU fan speed #36

wants to merge 1 commit into from

Conversation

clone1084
Copy link

@clone1084 clone1084 commented Aug 30, 2020 •
edited
Loading

Added CPU and GPU fan speed (based on HWiNFO data) in Large and Combo panels

CPU_GPU_fan_speed

in the image GPU fan is at 0 rpm because it's in quiet mode but it's working fine.

@clone1084
CPU and GPU fan speed
fd06b2c 
Added CPU and GPU fan speed (based on HWiNFO data) in Large and Combo panels
@wzub wzub mentioned this pull request Aug 31, 2020
Open
@wzub
Copy link

wzub commented Aug 31, 2020

Quite a coincidence that we submitted the same PR on the same day! Your implementation is much cleaner than mine (#35) and works great. Although my CPU Fan HWiNFOSensorId was 0xf7067960 instead of 0xf7067980. I made some small formatting and size adjustments and added your CPU detection to my edits as well. Thanks!

@MinhThienDX MinhThienDX self-assigned this Sep 1, 2020
@clone1084
Copy link
Author

Quite a coincidence that we submitted the same PR on the same day! Your implementation is much cleaner than mine (#35) and works great. Although my CPU Fan HWiNFOSensorId was 0xf7067960 instead of 0xf7067980. I made some small formatting and size adjustments and added your CPU detection to my edits as well. Thanks!

I was looking for the same thing and when I saw the topic I started modifying too ; )
Funny coincidence hahah

@MinhThienDX
Copy link
Owner

I think we should focus on #35 so I will close this PR.
Looking great guys 👏
Finally have an excuse to use button Close with comment 😂

@MinhThienDX MinhThienDX closed this Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MinhThienDX MinhThienDX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clone1084 @wzub @MinhThienDX