updated bip39 library, updated secp256k1 - fixed NPE after signing, t…

…est for leading zero address
MinterTeam · Jun 21, 2019 · f58d191 · f58d191
1 parent 3427769
commit f58d191
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -26,7 +26,7 @@ project build.gradle
 ```groovy
 
 ext {
-    minterSdkVersion = "0.3.2"
+    minterSdkVersion = "0.4.0"
 }
 
 dependencies {

diff --git a/RELEASE.md b/RELEASE.md
@@ -1,5 +1,9 @@
 # Release notes
 
+## 0.4.0
+ - Updated BIP39 library
+ - Updated secp256k1 library - fixed NPE after fail signing
+
 ## 0.3.2
  - Fixed RLP encoding for raw bytes contains leading zeroes
 

diff --git a/build.gradle b/build.gradle
@@ -90,14 +90,16 @@ apply plugin: 'maven-publish'
 apply plugin: 'com.jfrog.bintray'
 
 group = 'network.minter.android'
-version = '0.3.2'
+version = '0.4.0'
 
 def libPath = ""
 if(hasProperty("nativeLibPath")) {
     libPath = getProperty("nativeLibPath")
 }
 println "Native lib path: ${libPath}"
 
+
+
 android {
     compileSdkVersion minterMaxSdk
 
@@ -111,6 +113,7 @@ android {
 
         externalNativeBuild {
             cmake {
+                arguments '-DWITH_BIP39_TEST=Off', '-DENABLE_GO=Off', '-DENABLE_JNI=On', '-DENABLE_CONAN_BUILD=Off'
                 cppFlags "-std=c++14"
             }
         }
@@ -202,6 +205,7 @@ android {
     externalNativeBuild {
         cmake {
             path 'src/main/cpp/CMakeLists.txt'
+            version '3.10.2'
         }
     }
 }

diff --git a/src/main/cpp/bip39 b/src/main/cpp/bip39
diff --git a/src/main/cpp/secp256k1 b/src/main/cpp/secp256k1
diff --git a/src/test/java/network/minter/core/MinterAddressTest.java b/src/test/java/network/minter/core/MinterAddressTest.java
@@ -31,8 +31,6 @@
 import network.minter.core.crypto.MinterAddress;
 import network.minter.core.crypto.MinterPublicKey;
 import network.minter.core.crypto.UnsignedBytesData;
-import network.minter.core.internal.helpers.BytesHelper;
-import network.minter.core.internal.helpers.StringHelper;
 import network.minter.core.util.DecodeResult;
 import network.minter.core.util.RLPBoxed;
 
@@ -78,6 +76,25 @@ public void testFirstZeroBytesAddressRLP() {
 
     }
 
+    @Test
+    public void testFirstZeroBytesAddressArrayRLP() {
+        MinterAddress[] addresses = new MinterAddress[]{
+                new MinterAddress("Mx00aacae635ad329dc2a3f0509f947065703efc79"),
+                new MinterAddress("Mx00aacae635ad329dc2a3f0509f947065703efc79"),
+        };
+
+        char[] enc = RLPBoxed.encode(new Object[]{addresses});
+        DecodeResult res = RLPBoxed.decode(enc, 0);
+        Object[] dec = (Object[]) res.getDecoded();
+        Object[] dec0 = (Object[]) dec[0];
+        char[] add1 = (char[]) dec0[0];
+        char[] add2 = (char[]) dec0[1];
+
+        assertEquals(20, add1.length);
+        assertEquals(20, add2.length);
+
+    }
+
     @Test
     public void testFirstZeroBytesPubKeyRLP() {
         MinterPublicKey pk = new MinterPublicKey("Mp009b5528f09d1c74a83d18414f2e4263e14850c47a3fac3f855f200111111111");
+8 −1		CMakeLists.txt
+52 −0		packaging/build_all.sh
+27 −0		packaging/build_stretch.docker
+21 −0		packaging/init_build.sh
+4 −0		src/java/com/edwardstock/secp256k1/NativeSecp256k1.java