Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(proxying): fix Buffer not found issue by using proxy #16

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

MiracleUFO
Copy link
Owner

@MiracleUFO MiracleUFO commented Oct 11, 2023

BREAKING CHANGE
Moved translation request to proxy servers.
Issues with translation package necessitated moving some request logic to a proxy.

What?

  • Fix broken behavior of the component library (Buffer undefined etc) by using a proxy to make translation request

Why?

Error discovered in package on testing

Specific Changes

  • Use proxy server to make translation call instead of doing it inside component library

Testing

All tests for <Translate />, <Translator /> wrappers and getTranslation passed, and are found in src/tests

References

See README

This fixes the broken behavior of the component library.

BREAKING CHANGE
Moved translation request to proxy servers. Issues with translation package necessitated moving some request logic to a proxy
@MiracleUFO MiracleUFO self-assigned this Oct 11, 2023
@MiracleUFO MiracleUFO added the bug Something isn't working label Oct 11, 2023
@MiracleUFO MiracleUFO merged commit bd8044c into main Oct 11, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant