Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile MultiClusterService #476

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reconcile MultiClusterService #476

wants to merge 1 commit into from

Conversation

wahabmk
Copy link
Contributor

@wahabmk wahabmk commented Oct 11, 2024 •
edited
Loading

Description

  1. Implemented Reconcile for MultiClusterService.
  2. Does not implement status. That will be done in Implement Status for MultiClusterService #460.
  3. Some refactoring.

Sanity Testing

The following demo shows some sanity testing:

multiclusterservice-720p.mov

@wahabmk wahabmk self-assigned this Oct 11, 2024
@wahabmk wahabmk linked an issue Oct 11, 2024 that may be closed by this pull request
Implement Reconciliation for MultiClusterService #455
Open
@wahabmk wahabmk force-pushed the reconcile-multiclusterservice branch 12 times, most recently from c3cfc6b to 0739289 Compare October 11, 2024 13:43
@wahabmk wahabmk marked this pull request as ready for review October 11, 2024 13:47
zerospiel
zerospiel reviewed Oct 11, 2024
View reviewed changes
api/v1alpha1/managedcluster_types.go Show resolved Hide resolved
internal/controller/multiclusterservice_controller.go Outdated Show resolved Hide resolved
internal/controller/multiclusterservice_controller.go Outdated Show resolved Hide resolved
internal/controller/multiclusterservice_controller.go Outdated Show resolved Hide resolved
internal/sveltos/profile.go Outdated Show resolved Hide resolved
internal/sveltos/profile.go Show resolved Hide resolved
internal/sveltos/profile.go Show resolved Hide resolved
internal/sveltos/profile.go Show resolved Hide resolved
internal/sveltos/profile.go Outdated Show resolved Hide resolved
internal/sveltos/profile.go Outdated Show resolved Hide resolved
Schnitzel
Schnitzel requested changes Oct 14, 2024
View reviewed changes
api/v1alpha1/managedcluster_types.go Outdated Show resolved Hide resolved
@wahabmk wahabmk force-pushed the reconcile-multiclusterservice branch 4 times, most recently from 472d821 to f2fb0d4 Compare October 16, 2024 23:47
@wahabmk wahabmk force-pushed the reconcile-multiclusterservice branch from f2fb0d4 to bebe529 Compare October 17, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kshatrix Kshatrix Awaiting requested review from Kshatrix Kshatrix is a code owner

@eromanova eromanova Awaiting requested review from eromanova eromanova is a code owner

@a13x5 a13x5 Awaiting requested review from a13x5 a13x5 is a code owner

@squizzi squizzi Awaiting requested review from squizzi

@kylewuolle kylewuolle Awaiting requested review from kylewuolle

@slysunkin slysunkin Awaiting requested review from slysunkin

@Schnitzel Schnitzel Awaiting requested review from Schnitzel

@zerospiel zerospiel Awaiting requested review from zerospiel

Requested changes must be addressed to merge this pull request.

Assignees

@wahabmk wahabmk

Labels
None yet
Projects
Project 2A
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Reconciliation for MultiClusterService
3 participants
@wahabmk @Schnitzel @zerospiel