perf: batcher no-dict lookup for (Un)Reliable #3382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dict lookup uses 6% in an il2cpp build for 121 nts, this ugly patch brings that down to 0.x%
I don't like this from a code perspective, so lets talk if there's a better way
Do people actually use channel ids that are big? We could do an array lookup instead with the channelId as index if they dont
Or looping over a list to find the channel by id should be faster than using a Dict for 2 (or a handful) of values
Allowing more than the 2 default channels might be useful for some people, so I wouldnt advocate removing them outright
Bleh.