Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2.7] Updates #2462

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[4.2.7] Updates #2462

merged 2 commits into from
Nov 25, 2024

Conversation

ajinabraham
Copy link
Member

@ajinabraham ajinabraham commented Nov 25, 2024

Describe the Pull Request

  • Bump to google fork of baksmali 3.0.8
  • IPA: Graceful handling of plist dump exception

cc: @superpoussin22

Checklist for PR

  • Run MobSF unit tests and lint tox -e lint,test
  • Tested Working on Linux, Mac, Windows, and Docker
  • Add unit test for any new Web API (Refer: StaticAnalyzer/tests.py)
  • Make sure tests are passing on your PR MobSF tests

Additional Comments (if any)

DESCRIBE HERE

Copy link

👋 @ajinabraham
Thank you for sending this pull request ❤️.
Please make sure you have followed our contribution guidelines. We will review it as soon as possible

@superpoussin22
Copy link
Collaborator

great idea to move to Google version.
No issue so far on my side

@superpoussin22 superpoussin22 self-requested a review November 25, 2024 08:00
@ajinabraham ajinabraham merged commit a015df5 into master Nov 25, 2024
9 checks passed
@ajinabraham ajinabraham deleted the baksmali branch November 25, 2024 08:04
@ohyeah521
Copy link
Contributor

@ajinabraham We can set the version of baksmali in the setting to avoid having to modify multiple source code files at the same time every time we update baksmali.

@ajinabraham
Copy link
Member Author

We could, probably will be handled along with some code QA pass we are doing with apktool and other binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants