Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser platform support #81

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

lgrignon
Copy link

@lgrignon lgrignon commented Jun 20, 2018

Hello,
Could you please merge and deploy?
I needed to support browser support so I implemented it and tested on several projects.

Thanks for your time

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@lgrignon
Copy link
Author

I signed it!

1 similar comment
@lgrignon
Copy link
Author

lgrignon commented Jul 2, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@lgrignon lgrignon mentioned this pull request Jul 2, 2018
@krampstudio
Copy link

When trying to unzip with your fork I'm a having the following error :

TypeError: zip.BlobReader is not a constructor
    at VM10039 ZipProxy.js:295

@lgrignon
Copy link
Author

My bad, I didn't specify in the README
https://github.com/lgrignon/cordova-plugin-zip/blob/master/src/browser/README.md

That you need to include zip.js library in your app
https://github.com/gildas-lormeau/zip.js

I fixed the README as you can see.

It would be better if the plugin itself included the zip.js library but I had no more time + I was affraid about versions conflict in case some project already included zip.js library.
Anyway, I hope this will be good enough for you.

@sosek108
Copy link

any chance this will be merged?

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

lgrignon added 3 commits June 18, 2020 17:02
…installation & readme (we do not want global tsc installation but a local install with fixed version)
…installation & readme (we do not want global tsc installation but a local install with fixed version)
…installation & readme (we do not want global tsc installation but a local install with fixed version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants