GH-111: Add Privacy Manifest in Kronos #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
didix21
commented
Mar 20, 2024
•
didix21
commented
- Add PrivacyInfo.xcprivacy to Kronos.xcoproj.
- Add in the Privacy Manifest UserDefaults API with reason CA92.1.
- Include PrivacyInfo.xcprivacy file in the Package.swift.
- Upgrade minimum version of swift-tools-version to accept resources in Targets.
- Include PrivacyInfo.xcprivacy file in Pods file.
- Add PrivacyInfo.xcprivacy to Kronos.xcoproj. - Add in the Privacy Manifest UserDefaults API with reason CA92.1. - Include PRivacyInfo.xcprivacy file in the Package.swift. - Upgrade minimum version of swift-tools-version to accept resources in Targets. - Include PrivacyInfo.xcprivacy file in Pods file. Signed-off-by: Dídac Coll <[email protected]>
didix21
force-pushed
the
maintenance/iOS-2725-privacy-info
branch
from
dc06b4c
to
df7b966
Compare
|
It's mostly (ex) Lyft employees looking after this library—privacy manifests are on our radar so please stay tuned! |
lorderster
approved these changes
Apr 10, 2024
|
any updates on this? |
sberrevoets
approved these changes
Apr 18, 2024
|
Thanks for submitting! This looks good, the test failures here are obviously unrelated so working toward getting that fixed and seeing if we should just merge this in the meantime. |
|
That's great news! We're eager to see the next release of Kronos with Privacy Manifest compliance, as Apple's new policies will take effect on May 1. Is a codeowner able to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.