Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in the manifest file are not displayed #142

Closed
richfab opened this issue Oct 25, 2023 · 0 comments · Fixed by #143
Closed

Errors in the manifest file are not displayed #142

richfab opened this issue Oct 25, 2023 · 0 comments · Fixed by #143
Labels
bug Something isn't working

Comments

@richfab
Copy link
Contributor

richfab commented Oct 25, 2023 •
edited
Loading

What is the issue and why_ is it an issue?

When there are errors in the manifest.json file, the validation summary incorrectly displays "Invalid feed with 0 errors":
image

And the file report incorrectly shows that the file is valid although it contains errors:
image

It's an issue because producers that have errors in their manifest.json will not be able to know why their feed is invalid.

Steps to reproduce

  1. Visit https://gbfs-validator.mobilitydata.org/validator?url=https%3A%2F%2Fapi.ridecheck.app%2Fgbfs%2Fv3%2Famsterdam%2Fgbfs.json
  2. Observe that the summary displays "Invalid feed with 0 errors"
@richfab richfab added the bug Something isn't working label Oct 25, 2023
@richfab richfab mentioned this issue Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix manifest file validation MobilityData/gbfs-validator
1 participant
@richfab