Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manifest file validation #143

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix manifest file validation #143

merged 1 commit into from
Oct 30, 2023

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Oct 25, 2023

Fixes #142

Before After
gbfs-validator mobilitydata org_validator_url=https%3A%2F%2Fapi ridecheck app%2Fgbfs%2Fv3%2Famsterdam%2Fgbfs json (1) localhost_8080_validator_url=https%3A%2F%2Fapi ridecheck app%2Fgbfs%2Fv3%2Famsterdam%2Fgbfs json

Test feed for screenshots: https://api.ridecheck.app/gbfs/v3/amsterdam/gbfs.json

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for gbfs-validator ready!

Name Link
🔨 Latest commit 86e788e
🔍 Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/6539686c6b58730008c286fb
😎 Deploy Preview https://deploy-preview-143--gbfs-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@richfab
Copy link
Contributor Author

richfab commented Oct 25, 2023

It would be greatly appreciated if someone can please review this short PR when they have the bandwidth 🙏

It will help v3.0 producers identify errors in the manifest.json file. Thank you!

Tagging recent contributors @tdelmas @PierrickP @testower

Copy link
Collaborator

@testower testower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richfab
Copy link
Contributor Author

richfab commented Oct 25, 2023

At least 1 approving review is required by reviewers with write access.

@davidgamez can you please review as well? Thank you!

@richfab richfab merged commit a7c9095 into master Oct 30, 2023
8 checks passed
@richfab richfab deleted the fix/display-manifest-errors branch October 30, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in the manifest file are not displayed
3 participants