Small fixes for visualize v3.0 feed #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierrick <[email protected]>
✅ Deploy Preview for gbfs-validator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
richfab
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
LGTM. Merging now!
Thank you @PierrickP! It's super valuable to have the same versions supported by the visualization as the validator.
Were you able to try the visualization with a v3.0-RC feed yet? I'm looking forward to this :)
|
@richfab yes you can try with the Voi's feed translated to v3.0 by Entur |
|
Beautiful 😍
Notes: These Voi feeds are large so it can take several page refresh for the visualization to load successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.