Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required boolean (invalid) with required array #114

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Jul 7, 2023

What is it about?

The JSON schema used for GBFS feed validation was using an invalid property. The property required must take an array (reference) but it was taking a boolean.

The GBFS JSON schema was fixed in Replace required with boolean (invalid) to array.

This PR updates the schema in gbfs-validator.

Why does it matter?

A provider (TIER) is trying to update their GBFS feeds to v3.0, which is great! Unfortunately our validator is not so helpful now because it says the feed is valid although it's not. This PR will help the provider fix their feed.

Screenshots

https://data-sharing.tier-services.io/tier_paris/gbfs/3.0
image

Before After
image image
The validation report says gbfs.json is valid although it is not. The validation report correctly shows gbfs.json as invalid due to the extra en level.

@richfab richfab requested a review from PierrickP July 7, 2023 15:16
@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for gbfs-validator ready!

Name Link
🔨 Latest commit 4bb43a7
🔍 Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/64a82c3ae30813000809ca58
😎 Deploy Preview https://deploy-preview-114--gbfs-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2023

CLA assistant check
All committers have signed the CLA.

@richfab richfab requested a review from davidgamez July 7, 2023 15:16
@qcdyx qcdyx self-requested a review July 10, 2023 18:52
Copy link

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are straightforward and pretty clear to me. It's all good.

@richfab richfab merged commit ef43203 into master Jul 10, 2023
8 checks passed
@richfab richfab deleted the fix/gbfs-required-array branch July 10, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants