Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds file type if manifest.json file is not found #120

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Jul 13, 2023

Currently, when manifest_url is specified in system_information.json, but the file is not found at the URL, the validator fails.
Instead, the validator should inform that the manifest.json file is missing.

Fix #119

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for gbfs-validator ready!

Name Link
🔨 Latest commit 523fe7d
🔍 Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/64b06030b681bf000839255c
😎 Deploy Preview https://deploy-preview-120--gbfs-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@richfab richfab requested a review from davidgamez July 13, 2023 20:36
@richfab richfab changed the title Adds file type if manifest.json file is not found Adds file type if manifest.json file is not found Jul 13, 2023
@richfab richfab requested a review from PierrickP July 13, 2023 20:41
Copy link
Collaborator

@PierrickP PierrickP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test without the feed but for me this change fixes something :)

@richfab richfab merged commit 1f43f01 into master Jul 17, 2023
8 checks passed
@richfab richfab deleted the fix/manifest-json-file-not-found branch July 17, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix error when manifest.json file is not found
2 participants