Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OpenApi schema #171

Merged
merged 17 commits into from
Feb 23, 2024
Merged

feat: OpenApi schema #171

merged 17 commits into from
Feb 23, 2024

Conversation

davidgamez
Copy link
Member

@davidgamez davidgamez commented Feb 22, 2024 •
edited
Loading

Description

Changes:

  • Add OpenAPI specification file and Swagger UI.
  • Remove the functions that return dynamically the OpenAPI.
  • Add CORS support to feeds and validator functions.

Swagger UI is accessible at https://mobilitydata.github.io/gbfs-validator/SwaggerUI/index.html

Testing

For testing the SwaggerUI use the third server option: https://deploy-preview-171--gbfs-validator.netlify.app/.netlify/functions.

@netlify Netlify
Copy link

netlify bot commented Feb 22, 2024 •
edited
Loading

✅ Deploy Preview for gbfs-validator ready!

Name Link
🔨 Latest commit f3619f7
🔍 Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/65d8aac15815050008155819
😎 Deploy Preview https://deploy-preview-171--gbfs-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

davidgamez
davidgamez commented Feb 22, 2024
View reviewed changes
docs/gbfs-validator.yaml Outdated Show resolved Hide resolved
@davidgamez davidgamez marked this pull request as ready for review February 22, 2024 20:33
@davidgamez davidgamez changed the title feat: fix OpenApi schema feat: OpenApi schema Feb 22, 2024
jcpitre
jcpitre reviewed Feb 22, 2024
View reviewed changes
docs/gbfs-validator.yaml Outdated Show resolved Hide resolved
richfab
richfab approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👏 LGTM 🚀

I will let you do the merge as I see a comment: "REMOVE THIS URL BEFORE MERGING".
Thanks!

@davidgamez davidgamez merged commit bd991f9 into master Feb 23, 2024
10 checks passed
@davidgamez davidgamez deleted the feat/openapi-spec branch February 23, 2024 17:04
@richfab richfab mentioned this pull request Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmambd emmambd emmambd left review comments

@richfab richfab richfab approved these changes

@qcdyx qcdyx qcdyx approved these changes

@jcpitre jcpitre jcpitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidgamez @richfab @qcdyx @emmambd @jcpitre