Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New provider for Brest, FR #584

Merged
merged 3 commits into from
Jan 5, 2024
Merged

New provider for Brest, FR #584

merged 3 commits into from
Jan 5, 2024

Conversation

XioNoX
Copy link
Contributor

@XioNoX XioNoX commented Jan 4, 2024

Brest, FR doesn't have Donkey Republic bikes anymore. They have been replaced by a service called VéloZef. I used the "stable" API endpoint from:
https://www.data.gouv.fr/fr/datasets/velos-a-assistance-electrique-en-libre-service-velozef-sur-brest/

Brest, FR doesn't have Donkey Republic bikes anymore. They have been replaced by a service called VéloZef.
I used the "stable" API endpoint from:
https://www.data.gouv.fr/fr/datasets/velos-a-assistance-electrique-en-libre-service-velozef-sur-brest/
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2024

CLA assistant check
All committers have signed the CLA.

@richfab
Copy link
Contributor

richfab commented Jan 4, 2024

Hello Arzhel and welcome!
Thank you for this contribution, we love seeing new bike share systems! #bzh

@AntoineAugusti Can you please confirm that it's a best practice to use the stable URL from data.gouv in systems.csv?
image

@XioNoX
Copy link
Contributor Author

XioNoX commented Jan 4, 2024

Thanks for the quick reply.
Note that the operator provided URL includes a token, which seems quite brittle to me.
https://api.prod.partners-fs37hd8.zoov.eu/gbfs/2.2/brest/en/gbfs.json?&key=OGNhZDNjMDQtYTA0Yi00NzU2LWE0MTItOGJlYzE1Y2E4NGEx

@AntoineAugusti
Copy link
Contributor

@AntoineAugusti Can you please confirm that it's a best practice to use the stable URL from data.gouv in systems.csv?

When the feed is published by a third-party and not hosted on data.gouv.fr you can use the final URL directly.

Fifteen publishes feeds with tokens at the moment (to identify open data users) but the token is not added in URLs present in gbfs.json 😢 We got in touch with them about this and this may be fixed in the future.

@XioNoX
Copy link
Contributor Author

XioNoX commented Jan 4, 2024

Noted, thanks, PR updated. Is the answer from Fifteen a blocker to get this merged ? I guess any consumer of the data could re-append the key to the paths, but I agree its sub-optimal.

@AntoineAugusti
Copy link
Contributor

You shouldn't wait. I raised this issue with them more than 2 years ago, unfortunately.

@richfab richfab self-requested a review January 5, 2024 09:51
Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both for your help on this 🙏
Merging now 🚀

@richfab richfab merged commit eea9026 into MobilityData:master Jan 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants