Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Yes by REQUIRED in the spec #692

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Replace Yes by REQUIRED in the spec #692

merged 1 commit into from
Oct 14, 2024

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Oct 11, 2024 •
edited
Loading

This PR is a formatting change to the spec.

It replaces Yes by REQUIRED to be consistant with OPTIONAL and Conditionally REQUIRED values.

The REQUIRED value is self-explanatory whereas Yes requires to consult the header to understand the meaning.

Thank you @tdelmas for the suggestion 🙏

isabelle-dr
isabelle-dr approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@isabelle-dr isabelle-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@richfab richfab merged commit 20e7a1c into master Oct 14, 2024
1 check passed
@richfab richfab deleted the replace-yes-by-required-in-spec branch October 14, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelle-dr isabelle-dr isabelle-dr approved these changes

@Alessandro100 Alessandro100 Awaiting requested review from Alessandro100

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richfab @isabelle-dr