Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes at Emma's request #328

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Fixes at Emma's request #328

merged 6 commits into from
Feb 6, 2024

Conversation

fredericsimard
Copy link
Contributor

  • Removed empty parameters from Python function calls (ex. provider="").
  • Added [SOURCES] to branch name
  • statuses as lowercase
  • entity_type provided as an array.
  • Added note about not trying to fix """" from the script's output as this will cause an error when executed in the Python script.

@fredericsimard
Update add_new_or_updated_feeds.yml
93d6af4 
Added [SOURCES] to the branch name, as per Emma's request.
@fredericsimard
fix lowercased statuses values & entity as an array
a14931f 
As per Emma's request:
* entity type is an array
* the enum for status should all be lowercase, otherwise it breaks the tests
@fredericsimard
doc : Note added to not fix multiple double quotes (ex: """")
0a28d05
@fredericsimard
fix : remove empty parameters
59875d6 
As per Emma's request, remove all empty parameters from the python script functions.
@fredericsimard fredericsimard self-assigned this Feb 3, 2024
@fredericsimard fredericsimard merged commit a950e08 into main Feb 6, 2024
5 of 7 checks passed
@fredericsimard fredericsimard deleted the fix-emma-requests branch February 6, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmambd emmambd emmambd approved these changes

Assignees

@fredericsimard fredericsimard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredericsimard @emmambd