Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ben Franklin Transit Feed [SOURCES] #367

Merged
merged 4 commits into from
May 14, 2024
Merged

Ben Franklin Transit Feed [SOURCES] #367

merged 4 commits into from
May 14, 2024

Conversation

emmambd
Copy link
Contributor

@emmambd emmambd commented May 13, 2024

Ben Franklin Transit feed update as contributed by the transit agency.

Sergiodero
Sergiodero approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@Sergiodero Sergiodero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving the changes, just noting one thing: one of the checks in the automated commit didn't passed, is this okay?

@emmambd
Copy link
Contributor Author

emmambd commented May 14, 2024

@Sergiodero Looks like it passes now!

@emmambd emmambd merged commit 0f4a808 into main May 14, 2024
9 checks passed
@emmambd emmambd deleted the 2024-05-13-SOURCES branch May 14, 2024 16:19
@fredericsimard
Copy link
Contributor

@Sergiodero There was a timeout before for the URL, when using https, with http it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sergiodero Sergiodero Sergiodero approved these changes

@tzujenchanmbd tzujenchanmbd Awaiting requested review from tzujenchanmbd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmambd @fredericsimard @Sergiodero